search

fabiocolacio / Marker

🖊 A gtk3 markdown editor
GNU General Public License v3.0
836 stars 75 forks source link

App menu migration #244

Closed bertob closed 6 years ago

bertob commented 6 years ago

Application menus have been a source of usability issues since they were introduced, despite attempts to improve them. We are therefore aiming to end their use by 3.32.0.

In Marker's case this would be pretty easy:

See the wiki page for design guidelines.

fabiocolacio commented 6 years ago

Hi @bertob,

As it stands right now, users have the ability to move the appmenu contents to the hamburger menu in Marker's preferences. There has been some discussion in #233 about using gtk_application_prefers_appmenu() to decide where it should go instead.

I imagine that this is the best solution, rather than removing the appmenu outright, as it will fit in better with older versions of GNOME and other DE's that use the appmenu still.

Are we wrong to assume that gtk_application_prefers_appmenu() will return false in future versions of GNOME where the appmenu is deprecated?

bertob commented 6 years ago

I think you're correct in assuming that, so there shouldn't be any problems :)

AdrianVovk commented 5 years ago

This is still broken for me. I didn't even know that marker had a settings page because A) My DE has no app menu and B) Marker didn't notice this and kept using it. Maybe it's better to remove the setting outright after-all?