search

fabioformosa / quartz-manager

REST API and UI Console Manager for Quartz Scheduler. This is a Java Library & UI embeddable single page app, to control and monitor jobs scheduled with Quartz Scheduler
Apache License 2.0
232 stars 84 forks source link

Feature/#101 angular15 update #113

Open fabioformosa opened 5 months ago

fabioformosa commented 5 months ago

Some style regressions prevent to merge in the develop branch:

I leave the PR opened.

fabioformosa commented 5 months ago

Hi @midhunadarvin,

Observations

Style Mismatches

Font mismatch

Even though in CSS the family font seems unchanged, actually it looks like that the font family applied is different image image

Scrolling (regression)

In the prev version, when logs reach the bottom of the window, the log section scrolls while the window remains fixed. In the new version, the window scrolls too. image image

Font size mismatch

image image image image

Editable trigger name (regression)

In the prev version, in case of rescheduling, the trigger name was immutable. In the new version, it's mutable.

image image

[minor] mismatching of the padding in the dialog

image image

midhunadarvin commented 5 months ago

Hi @fabioformosa

  1. Font mismatch : Even though the font-family was given Roboto, Helvetica Neue, the fonts are not included either via build or cdn. I could see that on my machine it had font Helvetica Neue so it defaulted to it. If i am just using Roboto it defaulted to Times new roman as i did not have the font installed on my machine.

I have included Roboto fontface as npm dependency and included it in the build.

  1. Scrolling (regression) : It is fixed, please check.
  2. Font size mismatch : It is fixed, please check.
  3. Editable trigger name (regression) : It is fixed, but during testing i could find another issue. If a trigger job has been executed, rescheduling it causes a bug. I think it is because the trigger ( without repeat count ) is deleted from db by quartz scheduler.
  4. [minor] mismatching of the padding in the dialog : it is fixed, please check.
midhunadarvin commented 5 months ago

Hi @fabioformosa Anything pending on this PR ? Are we okay to merge this to develop ?

fabioformosa commented 5 months ago

There's still the font size mismatch. Apart from that, the angular team has released the last version of the flex-layout lib for angular 15 (https://www.npmjs.com/package/@angular/flex-layout). It should be the last call before closing the repo. Since the pure CSS is a temporary solution in the path towards tailwind and it introduced some style issues, I was thinking whether it's worth to upgrade flex-layout one last time and embrace directly tailwind preparing for angular 17.

midhunadarvin commented 5 months ago

In this PR, the latest version of @angular/flex-layout 15.0.0-beta.42 has been used. The style issues introduced were mainly due to the angular material library update.

I think reverting to flex-layout doesn't help much in the short run as it would be easier to migrate to tailwind from pure css rather than from flex-layout. So removing dependency from flex-layout little by little is advised, since flex-layout is deprecated.

fabioformosa commented 4 months ago

ok, it makes sense.

midhunadarvin commented 4 months ago

Hi @fabioformosa I have fixed the footer content font-size in https://github.com/fabioformosa/quartz-manager/pull/122

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud