Open holtwilkins opened 4 years ago
aaronhurt
commented
4 years ago Sorry, things have been very busy with the full-time gig lately. I'll try and work to get a release together soon. Apologies for the long delay between releases and thank you for the reminder.
holtwilkins
commented
4 years ago Hey @leprechau can I get an ETA here? Just trying to decide if it's worth creating my own docker image building pipeline for fabio in-house so we're not reliant on releases being cut. It's totally reasonable if you're answer is "I don't now and won't generally have time to cut releases regularly", and if so, I can just setup my pipeline, just let me know if you could :).
magiconair
commented
4 years ago If master is stable then I can cut a release today. Maybe then we can do a release every three months? Feb, May, Aug, Nov.
Would that work?
— Frank Schröder
On 11. Oct 2019, at 00:14, holtwilkins notifications@github.com wrote:
Hey @leprechau can I get an ETA here? Just trying to decide if it's worth creating my own docker image building pipeline for fabio in-house so we're not reliant on releases being cut. It's totally reasonable if you're answer is "I don't now and won't generally have time to cut releases regularly", and if so, I can just setup my pipeline, just let me know if you could :).
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
shantanugadgil
commented
4 years ago I am all for a frequent release schedule. Based on feature additions every month also seems good. Keeps the momentum, I think. But this is just my opinion. ☺️☺️☺️
magiconair
commented
4 years ago Also, if someone is willing to put in the effort to automate the release process with goreleaser all the way then we can probably release more often with less effort. Anybody willing to step up?
The current release process is here: https://github.com/fabiolb/fabio/wiki/Release-Checklist
magiconair
commented
4 years ago Note, we are already using goreleaser but there is still a substantial amount of manual steps.
magiconair
commented
4 years ago working on a release now. lets see how far I get. Haven't done this in a while.
magiconair
commented
4 years ago There is this problem with the modules:
verifying github.com/mwitkow/grpc-proxy@v0.0.0-20181017164139-0f1106ef9c76: checksum mismatch
downloaded: h1:0xuRacu/Zr+jX+KyLLPPktbwXqyOvnOPUQmMLzX1jxU=
go.sum: h1:LxaK681Aane3f53b4qVTXXq83lL9fWwBTaaZOf9VizA=but I can only see deltas in not-relevant files:
~/src/github.com/fabiolb/fabio $ ( cd ../../mwitkow/grpc-proxy && git log --oneline | head -1 )
0f1106e (HEAD -> master, origin/master, origin/HEAD) Move error checking further up (#34)
~/src/github.com/fabiolb/fabio $ diff -rq vendor/github.com/mwitkow/grpc-proxy ../../mwitkow/grpc-proxy
Only in ../../mwitkow/grpc-proxy: .git
Only in ../../mwitkow/grpc-proxy: .gitignore
Only in ../../mwitkow/grpc-proxy: .travis.yml
Only in ../../mwitkow/grpc-proxy: README.md
Only in ../../mwitkow/grpc-proxy: checkup.sh
Only in ../../mwitkow/grpc-proxy: fixup.sh
Files vendor/github.com/mwitkow/grpc-proxy/proxy/README.md and ../../mwitkow/grpc-proxy/proxy/README.md differ
Only in ../../mwitkow/grpc-proxy/proxy: codec_test.go
Only in ../../mwitkow/grpc-proxy/proxy: examples_test.go
Only in ../../mwitkow/grpc-proxy/proxy: handler_test.go
Only in ../../mwitkow/grpc-proxy: testserviceI vaguely remember that there was an issue with early go1.11betaX checksums.
magiconair
commented
4 years ago one more
verifying github.com/hashicorp/go-rootcerts@v0.0.0-20160503143440-6bb64b370b90: checksum mismatch
downloaded: h1:VBj0QYQ0u2MCJzBfeYXGexnAl17GsH1yidnoxCqqD9E=
go.sum: h1:9HVkPxOpo+yO93Ah4yrO67d/qh0fbLLWbKqhYjyHq9A= ~/src/github.com/fabiolb/fabio $ ( cd ../../hashicorp/go-rootcerts && git log --oneline | head -1 )
6bb64b3 (HEAD) Fix reversed err check so login keychain is loaded
~/src/github.com/fabiolb/fabio $ diff -rq vendor/github.com/hashicorp/go-rootcerts ../../hashicorp/go-rootcerts
Only in ../../hashicorp/go-rootcerts: .git
Only in ../../hashicorp/go-rootcerts: rootcerts_darwin_test.go
Only in ../../hashicorp/go-rootcerts: rootcerts_test.go
Only in ../../hashicorp/go-rootcerts: test-fixturesnext one
verifying github.com/apache/thrift@v0.0.0-20181028152738-da1169d75b15: checksum mismatch
downloaded: h1:GGI45yUJ942DZsI3uodzVabeRUbxPsioScY/EmmE5ek=
go.sum: h1:QMpU5E8/FWWRvfhkkX/R6hwoMbvVAV89qdKV/vfJogw=~/src/github.com/fabiolb/fabio $ ( cd ../../apache/thrift && git log --oneline | head -1 )
da1169d7 (HEAD) THRIFT-4653: ES6 classes support (#1615)
~/src/github.com/fabiolb/fabio $ diff -rq vendor/github.com/apache/thrift ../../apache/thrift
Only in ../../apache/thrift: .clang-format
Only in ../../apache/thrift: .dockerignore
Only in ../../apache/thrift: .editorconfig
Only in ../../apache/thrift: .eslintignore
Only in ../../apache/thrift: .eslintrc.json
Only in ../../apache/thrift: .git
Only in ../../apache/thrift: .gitattributes
Only in ../../apache/thrift: .gitignore
Only in ../../apache/thrift: .rustfmt.toml
Only in ../../apache/thrift: .travis.yml
Only in ../../apache/thrift: CHANGES
Only in ../../apache/thrift: CMakeLists.txt
Only in ../../apache/thrift: CONTRIBUTING.md
Only in ../../apache/thrift: LANGUAGES.md
Only in ../../apache/thrift: Makefile.am
Only in ../../apache/thrift: README.md
Only in ../../apache/thrift: Thrift-swift3.podspec
Only in ../../apache/thrift: Thrift.podspec
Only in ../../apache/thrift: aclocal
Only in ../../apache/thrift: appveyor.yml
Only in ../../apache/thrift: bootstrap.sh
Only in ../../apache/thrift: bower.json
Only in ../../apache/thrift: build
Only in ../../apache/thrift: cleanup.sh
Only in ../../apache/thrift: compiler
Only in ../../apache/thrift: composer.json
Only in ../../apache/thrift: configure.ac
Only in ../../apache/thrift: contrib
Only in ../../apache/thrift: debian
Only in ../../apache/thrift: doap.rdf
Only in ../../apache/thrift: doc
Only in ../../apache/thrift: dub.json
Only in ../../apache/thrift/lib: Makefile.am
Only in ../../apache/thrift/lib: as3
Only in ../../apache/thrift/lib: c_glib
Only in ../../apache/thrift/lib: cl
Only in ../../apache/thrift/lib: cocoa
Only in ../../apache/thrift/lib: cpp
Only in ../../apache/thrift/lib: csharp
Only in ../../apache/thrift/lib: d
Only in ../../apache/thrift/lib: dart
Only in ../../apache/thrift/lib: delphi
Only in ../../apache/thrift/lib: erl
Only in ../../apache/thrift/lib/go: Makefile.am
Only in ../../apache/thrift/lib/go: README.md
Only in ../../apache/thrift/lib/go: coding_standards.md
Only in ../../apache/thrift/lib/go: test
Only in ../../apache/thrift/lib/go/thrift: application_exception_test.go
Only in ../../apache/thrift/lib/go/thrift: binary_protocol_test.go
Only in ../../apache/thrift/lib/go/thrift: buffered_transport_test.go
Only in ../../apache/thrift/lib/go/thrift: common_test.go
Only in ../../apache/thrift/lib/go/thrift: compact_protocol_test.go
Only in ../../apache/thrift/lib/go/thrift: exception_test.go
Only in ../../apache/thrift/lib/go/thrift: framed_transport_test.go
Only in ../../apache/thrift/lib/go/thrift: http_client_test.go
Only in ../../apache/thrift/lib/go/thrift: iostream_transport_test.go
Only in ../../apache/thrift/lib/go/thrift: json_protocol_test.go
Only in ../../apache/thrift/lib/go/thrift: lowlevel_benchmarks_test.go
Only in ../../apache/thrift/lib/go/thrift: memory_buffer_test.go
Only in ../../apache/thrift/lib/go/thrift: protocol_test.go
Only in ../../apache/thrift/lib/go/thrift: rich_transport_test.go
Only in ../../apache/thrift/lib/go/thrift: serializer_test.go
Only in ../../apache/thrift/lib/go/thrift: serializer_types_test.go
Only in ../../apache/thrift/lib/go/thrift: server_socket_test.go
Only in ../../apache/thrift/lib/go/thrift: server_test.go
Only in ../../apache/thrift/lib/go/thrift: simple_json_protocol_test.go
Only in ../../apache/thrift/lib/go/thrift: simple_server_test.go
Only in ../../apache/thrift/lib/go/thrift: transport_exception_test.go
Only in ../../apache/thrift/lib/go/thrift: transport_test.go
Only in ../../apache/thrift/lib/go/thrift: zlib_transport_test.go
Only in ../../apache/thrift/lib: haxe
Only in ../../apache/thrift/lib: hs
Only in ../../apache/thrift/lib: java
Only in ../../apache/thrift/lib: javame
Only in ../../apache/thrift/lib: js
Only in ../../apache/thrift/lib: json
Only in ../../apache/thrift/lib: lua
Only in ../../apache/thrift/lib: netcore
Only in ../../apache/thrift/lib: nodejs
Only in ../../apache/thrift/lib: ocaml
Only in ../../apache/thrift/lib: perl
Only in ../../apache/thrift/lib: php
Only in ../../apache/thrift/lib: py
Only in ../../apache/thrift/lib: rb
Only in ../../apache/thrift/lib: rs
Only in ../../apache/thrift/lib: st
Only in ../../apache/thrift/lib: swift
Only in ../../apache/thrift/lib: ts
Only in ../../apache/thrift/lib: xml
Only in ../../apache/thrift: package-lock.json
Only in ../../apache/thrift: package.json
Only in ../../apache/thrift: phpcs.xml.dist
Only in ../../apache/thrift: pull_request_template.md
Only in ../../apache/thrift: sonar-project.properties
Only in ../../apache/thrift: test
Only in ../../apache/thrift: tutorialpushed some cleanup.
magiconair
commented
4 years ago codeship green
magiconair
commented
4 years ago OK, it is done. v1.5.12 is tagged and shipped.
However, first and foremost the appreciation belongs to @leprechau and @pschultz together with all the committers and contributors who kept fabio going. Thank you both and the rest for doing so much for this project.
As I've said before: this project has gone way way beyond what I ever wanted to solve and has an active community.
I think what I can realistically commit to is to run the releases every couple of months but we need people who take on the task of responding to issues, reviewing PRs, and merging them.
If someone is interested in doing this and investing some time into this project then feel free to contact me either here or you can find me on keybase.io if you want a more private conversation first. Also, @leprechau and @pschultz let me know how you feel about working on fabio a bit more.
Thank you Frank
magiconair
commented
4 years ago Just tagged and released v1.5.13
Hey @magiconair or @leprechau , it's been awhile since there's been a fabio release. We're getting bitten by the buffering issue fixed in https://github.com/fabiolb/fabio/pull/655 . Can we get a release tagged if everything's g2g?