fabiolb / fabio

Consul Load-Balancing made simple
https://fabiolb.net
MIT License
7.27k stars 616 forks source link

Safely handle missing cert from Vault KV store #710

Closed dradtke closed 5 years ago

dradtke commented 5 years ago

I have certificates saved in Vault using its KV engine version 2, and Fabio started panicking after I deleted an unused certificate. The fix was to run vault kv metadata delete <cert> to clean up the metadata as well, but Fabio should be able to avoid panicking in this case.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

aaronhurt commented 5 years ago

Good catch, thank you!