search

fabiolb / fabio

Consul Load-Balancing made simple
https://fabiolb.net
MIT License
7.25k stars 620 forks source link

Fix x-forwarded-for header processing for ws connections #860

Closed bn0ir closed 2 years ago

bn0ir commented 2 years ago

Fix x-forwarded-for header processing logic for ws connections. Instead of simply use remoteIP as x-forwarded-for header for backend, server add remoteIP to the end of x-forwarded-for header from client and send result to backend.

This PR possibly connected with issue https://github.com/fabiolb/fabio/issues/828

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

nathanejohnson commented 2 years ago

@leprechau could you take a look at this one? This rings of this old thread:

https://github.com/fabiolb/fabio/pull/449

aaronhurt commented 2 years ago

Agreed, we should be trying to mirror the functionality in the standard library where possible. This also shouldn't have an impact on the ACL functionality.

ketzacoatl commented 2 years ago

@nathanejohnson / @leprechau can this be released in a v1.6.1?