search

fabiolb / fabio

Consul Load-Balancing made simple
https://fabiolb.net
MIT License
7.25k stars 620 forks source link

Add IdleConnTimeout configurable for http transport #863

Closed aal89 closed 2 years ago

aal89 commented 2 years ago

Please see this issue for additional context https://github.com/fabiolb/fabio/issues/862.

I set a default value for IdleConnTimeout of 15s, because the KeepAliveTimeout default is 0s and net.Dialer will make it into a 15s default if it's 0s.

Thank you for reviewing.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

nathanejohnson commented 2 years ago

Thank you for your contribution!

aal89 commented 2 years ago

Do we need to update some documentation too? This a quite a behavioural change as Fabio will now have a 15s keepalive for connections.