fabiolb / fabio

Consul Load-Balancing made simple
https://fabiolb.net
MIT License
7.25k stars 620 forks source link

#865 Move the route table sort into NewTable so that it only happens once. #867

Closed ddreier closed 2 years ago

ddreier commented 2 years ago

Addresses #865 where route table updates take multiple minutes with tens of thousands of routes.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

nathanejohnson commented 2 years ago

So I have to ask... why do you guys have so many routes? :)

ddreier commented 2 years ago

So I have to ask... why do you guys have so many routes? :)

We like to ask ourselves the same thing 😄

Our Production Nomad clusters each run around 20k Allocations (we run mostly single-tenant services). Depending on the actual application, there could be as many as 6 or 8 routes registered per Alloc. So it ends up that we have Fabio instances for a couple of networks that have 60k routes.

nathanejohnson commented 2 years ago

Thank you for your contribution!

ddreier commented 2 years ago

Thanks @nathanejohnson! Any hint on when the next version might be released? 😄

nathanejohnson commented 2 years ago

@ddreier it was just released today.