fabiolb / fabio

Consul Load-Balancing made simple
https://fabiolb.net
MIT License
7.25k stars 620 forks source link

Fabio is using Datadog reserved tag keys #923

Open froque opened 1 year ago

froque commented 1 year ago

Some metrics are sent with tags service, host, path, target:

https://github.com/fabiolb/fabio/blob/642e425cf664e23d257ca357b7b1bfd1e432683d/route/route.go#L64-L66

But service and host are reserved tag keys in Datadog

According to Host tag

The host tag is assigned automatically by the Datadog Agent aggregating the metrics. Metrics submitted with a host tag not matching the Agent hostname lose reference to the original host. The submitted host tag overrides any hostname collected by or configured in the Agent.

and https://github.com/DataDog/datadog-agent/issues/6245, these metric loose any configuration in the datadog-agent. In our case it is the env tag that is being lost.

It can be tested with:

echo -n "custom.metric.nameA:1|c|#host:foo" |nc -vu -w1 localhost 8125

image

echo -n "custom.metric.nameB:1|c|#host1:foo" |nc -vu -w1 localhost 8125

Screenshot 2023-02-07 at 11-35-13 Metrics Summary Datadog2

ngcmac commented 1 year ago

Any news on this?