fabiolb / fabio

Consul Load-Balancing made simple
https://fabiolb.net
MIT License
7.25k stars 620 forks source link

Potential goroutine leak in server.go #930

Open hhheiaenia opened 1 year ago

hhheiaenia commented 1 year ago

I found that the ctx.Done() in L125 cannot be guaranteed to receive the cancel signal in https://github.com/fabiolb/fabio/blob/master/proxy/tcp/server.go, for the invocation in https://github.com/fabiolb/fabio/blob/master/proxy/inetaf_tcpproxy.go#L91 doesn't invoke the cancelFunc of this context.

I am not sure what I said is right. So I am looking forward to your reply.