search

fabiomcosta / mootools-meio-autocomplete

A complete mootools Autocomplete plugin
http://www.meiocodigo.com/projects/meio-autocomplete/
32 stars 14 forks source link

Fix Ajax request timing issue. #12

Closed oscherler closed 12 years ago

oscherler commented 12 years ago

Fix Ajax request timing issue with link: 'cancel' option. #7

fabiomcosta commented 12 years ago

I actually merged as you can see, but an error on github happened and It looks unmerged.

But it's fine, see here: https://github.com/fabiomcosta/mootools-meio-autocomplete/commit/87f6e07c1d84354476a502a76075eebbb8c479c4

Thank you!

oscherler commented 12 years ago

My minified version is broken, though. It gives me this error:

Meio.Autocomplete.min.js:38
TypeError: 'undefined' is not a function (near '...this,document.id||$)(function(b,c){var d...')

I used yuicompressor-2.4.7, but I had never used it before, so maybe it’s safer if you re-minify it with your tools.

fabiomcosta commented 12 years ago

@oscherler, go inside the project's folder and do make, did you try it out?

fabiomcosta commented 12 years ago

This instructions are here: https://github.com/fabiomcosta/mootools-meio-mask#building I just dont want to have a min file inside the repository since I would have to regenrate it from the files we still got inside the repository. It's like keeping a compiled binary inside the repo.

oscherler commented 12 years ago

I just dont want to have a min file inside the repository since I would have to regenrate it from the files we still got inside the repository. It's like keeping a compiled binary inside the repo.

I understand that, but the Build folder and the min file were already there (by mistake, probably) so I thought you wanted to have them in.

Also, the mootools-meio-autocomplete is missing its Makefile, and build.py is referencing ../../assets/yui-compressor/yui.jar (it has no yui.jar in Assets). I’ll try and pick the files from mootools-meio-mask and see what I can do.

fabiomcosta commented 12 years ago

@oscherler are you using the master branch? I mean, its working here, and I just cloned the repository

fabiomcosta commented 12 years ago

Oh, are you getting the last tag?