search

fabiopelosin / Ikeda

11 stars 1 forks source link

Remove HUD from the dropdown. #6

Closed jwilling closed 12 years ago

jwilling commented 12 years ago

OS X has a weird bug with content borders and sheets. That means there's weird invisible corners on the edges of the sheets. Nothing I can do about it, unfortunately.

fabiopelosin commented 12 years ago

Have you investigated using a NSPanel? It doesn't have the rounded borders. I think that we should aim for a look similar to the preview window that Xcode presents on refactoring.

jwilling commented 12 years ago

By the way, I think something is messed up with the gitignore.

alloy commented 12 years ago

https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/AppleHIGuidelines/Windows/Windows.html#//apple_ref/doc/uid/20000961-TP9

A NSPanel is not meant for this:

“A panel floats above other windows and provides tools or controls that users can work with while documents are open. In some cases, a panel can be transparent.”

It should imo definitely be a sheet dialog:

In general, a sheet is a good way to present:

  • A modal dialog for an activity that is specific to a particular document, such as exporting, attaching files, or printing.
  • A modal dialog that is specific to a single-window app that does not create documents. For example, a single-window utility app might use a sheet to request acceptance of a licensing agreement from the user.
jwilling commented 12 years ago

@alloy I changed the class to NSPanel, but it's still a sheet. It just affects how the bottom border looks in this case.

alloy commented 12 years ago

Oh I see, my bad.

fabiopelosin commented 12 years ago

By the way, I think something is messed up with the gitignore.

What did you observe?

Btw, I'm considering removing the pods folder out of the repo to limit the noise, any feedback about it?

alloy commented 12 years ago

(I’ve removed the .DS_Store files btw and added to gitignore.)

jwilling commented 12 years ago

Btw, I'm considering removing the pods folder out of the repo to limit the noise, any feedback about it?

Or you could just add it to the .gitignore, which is what I usually do on my projects.

fabiopelosin commented 12 years ago

Looks good, I'm merging it.

(I've added you both as collaborator to simplify things a bit)

fabiopelosin commented 12 years ago

Or you could just add it to the .gitignore, which is what I usually do on my projects.

Sorry, this is what I meant. Done.

(I’ve removed the .DS_Store files btw and added to gitignore.)

Done in master.

jwilling commented 12 years ago

Thanks. :sparkles:

fabiopelosin commented 12 years ago

Btw, I think that we should have another manifest in the Pods folder which is a copy of the Podfile.lock (intended not to be under source control) which CocoaPods should checks against to tell if the Pods folder is out of sync with the Podfile.lock so we can fail the build.