search

fabiorino / crelly-slider

A free responsive slider for WordPress that supports layers. Add texts, images, videos and beautify them with transitions and animations.
MIT License
105 stars 36 forks source link

Flash of Unstyled Content #2

Closed javistuff closed 9 years ago

javistuff commented 9 years ago

Hi guys!

First, let me tell you, the slider looks great. I'm truly happy there's a plugin like yours in the repo. We are adding (a little more dedicated) support for your plugin to a theme of ours and we are noticing a flashing of the < ul > element with a shorter height version of the slides even before the loader comes in.

We've tried all sorts of display:none en several elements, seeing that the slides get shown via a a javascript display:block action, but with no success at all.

Have you seen this happening? Any clue of what could we do to avoid this flashing?

fabiorino commented 9 years ago

Hi, I know this bug, It has been reported by another user. To fix it, a JavaScript modification is required. It will be patched in the next release of Crelly Slider.

javistuff commented 9 years ago

Oh, that's great! Just out of curiosity, do you happen to know where that modification would go? I've been scanning the .js file and couldn't find anything actually loaded before the setPreloader() function that would cause the slides to show up.

Sorry about the nudging, by the way. Is just the anxiety of finally having a GPL slider to recommend our users. :)

fabiorino commented 9 years ago

I think the problem is that the preloader is displayed on document.ready() - that fires when the ENTIRE html document is ready - but the < ul > is displayed as soon as it loads (and it loads faster than document.ready()). My idea is to add a style="display: none;" to the .crellyslider-slider div, directly from the frontend.php file. "display: none;" will be replaced with a "display: block;" when the js file is ready. I'm doing tests.

javistuff commented 9 years ago

Yup! I found that too. The style="display: none;" does take away the < ul > indeed. I'm not able to bring it back yet, but I'm not that familiarized with this plugin's code as you, of course. Let me know if I can do something to help.

fabiorino commented 9 years ago

If it's urgent I can send you via email the current development version of Crelly Slider.

javistuff commented 9 years ago

If you manage to have that working that would be incredible useful because we already have the slider working on one of our themes' demo. Can you mail it to contact (at) quadroideas.com? Again, I'm happy to have found a plugin with such a committed developer behind it. Thanks for your help!

fabiorino commented 9 years ago

Thank you for your kind words. Please, check your email.

javistuff commented 9 years ago

Alright, I just did. You are a genius! I'll reply there.

cooperlovano commented 5 years ago

Hello! I am having this same problem (the slider loads going down the whole page before it becomes styled to display as a slider) https://www.cooperlovano.design/

Is there a solution that you found that I can use? Thanks so much! Beautiful plugin

fabiorino commented 5 years ago

@cooperlovano the site you provided doesn't have Crelly Slider installed