fabiorino / crelly-slider

A free responsive slider for WordPress that supports layers. Add texts, images, videos and beautify them with transitions and animations.
MIT License
104 stars 36 forks source link

Full height support #38

Open AlecRust opened 7 years ago

AlecRust commented 7 years ago

I notice you say this plugin is only full-width, not full-height.

I think support for full-height sliders (example) would set this plugin apart from others which often require the "pro" version for this feature.

Any reason this hasn't been added/are you open to this being added?

amarbeslija commented 7 years ago

Because, you can controll width and height on your own. Also, when something is responsive, it means that elements width is responsive, not height. You can control one thing, but you can't control both things automatically, because elements will break somehow. Only real solution is manual control, and you can do that with media queries (css). Every browser usually control elements height, with percents (read: number of pixels) from calculation of width. So, in here, you tell browser which is your width and height, and it calculate height while reducing width to optimum for device.

I am not telling that full, responsive height isn't possible, but I think it requires a lot of hard work to get it, and even then, you will have to do some manually work. Also, I think it is not necessary for anyone.

Working solution: Because this slider works perfectly on every device (it is really responsive), exepct on mobile (because mobiles are to small in normal alignment, not because of slider), you, and everyone can make one slider for all devices, and one just for mobile. It is not a lot of work, but you can get really good stuff from that.

Best regards.

tomhayes commented 7 years ago

Why can't you control height with height:100vh or using calc to accommodate for header etc - eg height:calc(100vh-150px)? Seems to work ok for most use cases.

fabiorino commented 7 years ago

Other major sliders have full height support. It's something that I want to implement in the future, but I have other priorities for now.

For Tom-Hayes: that could work but it's just too hard to implement in the current engine of the plugin since it's completely based on math calculations done in Javascript

applibs commented 4 years ago

What it the process of this?