search

fabiorino / crelly-slider

A free responsive slider for WordPress that supports layers. Add texts, images, videos and beautify them with transitions and animations.
MIT License
105 stars 36 forks source link

In /wp-admin/admin.php?page=crellyslider&view=edit&id=1 #5

Closed eduardoarandah closed 9 years ago

eduardoarandah commented 9 years ago

table "slide options" css was missing a clear:left

eduardoarandah commented 9 years ago

Found this bug and made the fix thank you for the amazing work! before after

eduardoarandah commented 9 years ago

Hi! I created the language files 100% complete for spanish and fixed the loading of language files. it's ready to pull =)

fabiorino commented 9 years ago

Hi, thank you really much for what you are doing. 2 things (I'm relatively new to GitHub and I don't know if the discussion is the right section to ask):

1)I'd like to keep the language folder into the wordpress folder. In this way, the JS plugin and the backend interface are as much as standalone as possible.

2) The load_language_files should() be called crellyslider_loadLanguageFiles(). Prefixes avoid conflicts.

I'd do these little things by myself but I'm not sure if I have to merge the pull request or I have to wait your modifications and then merge (again, sorry, but this is my first project on GitHub).

eduardoarandah commented 9 years ago

Yes, this is the perfect place for discussions. Or "issues" you can make as many as you want.

I suggest you merge my changes, commit, make your changes, commit, then push to github.

I will keep an eye on this project, I like it a lot! It is fast, light and easy to use. Keep it simple!

I used it here: http://smilexalapa.com/

El jueves, 5 de marzo de 2015, fabiorino notifications@github.com escribió:

Hi, thank you really much for what you are doing. 2 things (I'm relatively new to GitHub and I don't know if the discussion is the right section to ask):

1)I'd like to keep the language folder into the wordpress folder. In this way, the JS plugin and the backend interface are as much as standalone as possible.

2) The load_language_files should() be called crellyslider_loadLanguageFiles(). Prefixes avoid conflicts.

I'd do these little things by myself but I'm not sure if I have to merge the pull request or I have to wait your modifications and then merge (again, sorry, but this is my first project on GitHub).

— Reply to this email directly or view it on GitHub https://github.com/fabiorino/crelly-slider/pull/5#issuecomment-77431070.

Enviado desde mi móvil