search

fabiorino / crelly-slider

A free responsive slider for WordPress that supports layers. Add texts, images, videos and beautify them with transitions and animations.
MIT License
104 stars 36 forks source link

line-height 'normal' #53

Closed dlaxar closed 6 years ago

dlaxar commented 6 years ago

When no line-height is set on the element itself (or e.g. inherit is used), then the line-height is supplied by the browser. The default line-height in all browsers is normal.

Most browsers (FF, for example) return the actual px-value when queried. Some browsers, however, return the string normal (the current Chrome 62 for, example).

Trying to convert normal to float leads to the coefficient being 0 and thus a line-height of 0px.

The value normal usually computes to something between 1.0 and 1.2. This fix uses a value of 1.15 as the coefficient.

See http://meyerweb.com/eric/thoughts/2008/05/06/line-height-abnormal/ for even more details on this.

Best regards, Daniel

dlaxar commented 6 years ago

Hi @fabiorino,

is there any news on this? I really think this is an important fix because this might be a show-stopper for people trying to integrate crelly-slider with the site's CSS.

All the best, Daniel

fabiorino commented 6 years ago

Hi, I'm so sorry, with exams and stuff I forgot about this post. I'll get on this next week, I need some days to take my first 2 exams.

fabiorino commented 6 years ago

Tested and merged, thanks!