fabiorino / crelly-slider

A free responsive slider for WordPress that supports layers. Add texts, images, videos and beautify them with transitions and animations.
MIT License
104 stars 36 forks source link

Remove YouTube player controls & video info. #57

Open Nullcaller opened 6 years ago

Nullcaller commented 6 years ago

Quick google search shows that you can do it by adding controls=0 and showinfo=0 GET parameters to the video link. But to add this to the link the slider uses, you either need to use jQuery to parse the link, and replace the old one with a new, or you need to use XSS-ish kind of way of adding to video id in slider settings like <video_id>?controls=0&showinfo=0&, which breaks the whole slider with YouTube player failing to attach to the DOM (whatever that means).

And just if you were wondering, YouTube is perfectly fine with, since they have their logo in the lower right corner anyway. Also, apparently, YouTube hasn't changed since at least 2014, so it's not like to change in the near future. And there is no reason, HTML 5 player is the latest tech already, and it's not like to change too.

So... Shouldn't there be a more native way to turn off controls & info, like Yes/No box, like the ones that slider already has a lot of?