Octokit Auth and Token from ENV

fabiospampinato / bump

Bump updates the project's version, updates/creates the changelog, makes the bump commit, tags the bump commit and makes the release to GitHub. Opinionated but configurable.

MIT License

412 stars 13 forks source link

Octokit Auth and Token from ENV #6

Closed dlanileonardo closed 5 years ago

dlanileonardo commented 5 years ago

I think its better:

$ export GITHUB_API_TOKEN=token_here

# bump.json
...
"github": {
  "token": "GITHUB_API_TOKEN"
}

fabiospampinato commented 5 years ago

Hey, I like the idea, but:

I don't think it's worth it to make the environment key configurable, just name it "GITHUB_TOKEN" maybe.
I think instead of modifying release/github.ts we just need to retrive the token from the environment variables and put it in the config object.

dlanileonardo commented 5 years ago

Good Idea!!!! 😄
I Kept change in github.ts, because authenticate method it is deprecated.

fabiospampinato commented 5 years ago

Available in v1.1 👍