Figure out what to do with .gitignore files between the cwd and the search root

fabiospampinato / tiny-readdir-glob-gitignore

A simple promisified recursive readdir function, with support for globs and .gitignore files.

MIT License

13 stars 0 forks source link

Figure out what to do with .gitignore files between the cwd and the search root #1

Closed fabiospampinato closed 7 months ago

fabiospampinato commented 7 months ago

Currently when searching inside cwd, with glob like foo/**/*, really we are searching only inside cwd/foo. That is potentially a problem for discovering .gitignore files.

When ignoreFilesFindAbove is true we may be missing cwd/.gitignore.
When ignoreFilesFindAbove is false it's unclear whether we should actually read cwd/.gitignore or not.

fabiospampinato commented 7 months ago

Fixed in v1.0.1. Basically it's as if the search root optimization didn't exist, as far as looking for gitignore files is concerned.