search

fabiospampinato / vscode-diff

Diff 2 opened files with ease. Because running `code --diff path1 path2` is too slow.
MIT License
40 stars 9 forks source link

Support `.gitignore` #4

Closed muuvmuuv closed 7 months ago

muuvmuuv commented 5 years ago

I have noticed that it also shows .git files etc. Would be great if I could turn an option on to tell diff that it should ignore certain files or by file.

fabiospampinato commented 5 years ago

Files from ./.git shouldn't be displayed 🤔 If that's the case I'd consider this a bug.

Supporting .gitignore sounds like a good addition, PRs welcome 👍

okwme commented 5 years ago

for me it's also running a search on all files inside of node_modules, this is taking a really long time and actually breaking

stefanobartoletti commented 5 years ago

I also think that ignoring the content of node_modules by default (or at least letting the user chose to do so with an option, maybe?) would be a nice addition and would speed up its use.

muuvmuuv commented 5 years ago

.git-files are not longer in the tree but I agree with @stefano-b that node_modules shouldn't be in the list as well. Plus I would ignore common directories like:

muuvmuuv commented 5 years ago

I think showing opened files in the tree first would be a nice enhancement as well

fabiospampinato commented 3 years ago

This extension should respect the "files.exclude" setting, you should put stuff to exclude there.

fabiospampinato commented 7 months ago

This is supported in v2, there's a new setting, diff.ignore, to set the files to consider as gitignore files.