search

fabiospampinato / vscode-highlight

Advanced text highlighter based on regexes. Useful for todos, annotations etc.
MIT License
168 stars 28 forks source link

Theme-scoped settings #49

Open flux627 opened 4 years ago

flux627 commented 4 years ago

It would be nice to be able to define options that are only active when certain themes are active. I have a few themes I cycle through, and would like to configure my highlight colors to match the current theme I'm on without having to open my settings and comment/uncomment corresponding blocks.

fabiospampinato commented 4 years ago

The probably better fix here would be being able to reference your current theme's colors rather than hardcoding values, which is impossible today AFAIK: microsoft/vscode#32813

I'm not sure if it's possible to implement per-theme settings 🤔

yzhang-gh commented 4 years ago

Maybe we can add a filterTheme just like filterLanguageRegex?

I have been using a dark theme until I found a great light theme.

fabiospampinato commented 4 years ago

Maybe we can add a filterTheme just like filterLanguageRegex?

PR welcome 👍

yzhang-gh commented 4 years ago

Will try when I get some time 🤪

rioj7 commented 3 years ago

PR #62 is a possible solution for this