Enviroment variables support

fabiospampinato / vscode-terminals

An extension for setting-up multiple terminals at once, or just running some commands.

MIT License

121 stars 19 forks source link

Closed M-Zuber closed 6 years ago

M-Zuber commented 6 years ago

Can set environment variables to be applied to a specific terminal, or globally to any terminal opened through the extension fixes #10

fabiospampinato commented 6 years ago

Thanks! I like the idea of also supporting global env variables. I'm going to rewrite this a bit though before publishing it.

M-Zuber commented 6 years ago

My pleasure

I'm going to rewrite this a bit though before publishing it.

Of course! I will try and pay attention though, so next time you hopefully won't need to 😄

fabiospampinato commented 6 years ago

Published in v1.9.0, check out my commit.

Notable changes:

I had to workaround a bug in VSC.
I actually bumped the minimum engine version.
I added the new terminals.env setting in package.json
You were extending the env in the wrong order (a terminal's env should overwrite the global env, not the other way around).
Renamed applyGobalEnv to envInherit, when we'll have support for groups this name would make more sense.

Thanks again for your PR, feel welcome to submit another one in the future.

M-Zuber commented 6 years ago

Awesome! Thank you for taking the time to write this up for me

I actually bumped the minimum engine version.

oops..