search

fabiospampinato / vscode-terminals

An extension for setting-up multiple terminals at once, or just running some commands.
MIT License
121 stars 20 forks source link

'isExtensible' on proxy: trap result does not reflect extensibility of proxy target (which is 'true') #32

Closed aeschli closed 4 years ago

aeschli commented 5 years ago

From https://github.com/microsoft/vscode/issues/80976

Issue Type: Bug

I do not know if this should be reported here or after electron update there is requirement to change something in vscode-terminals repository. Happens only in exploration and latest insider with electron 6.0.9, Works in previous insider and stable.

  1. Install https://github.com/fabiospampinato/vscode-terminals/
  2. Configure any terminal 
    "terminals.terminals": [
    {
        "name": "Git Bash",
        "shellPath": "${env:SCOOP}\\apps\\git\\current\\bin\\bash.exe",
        "focus": true,
        "open": true,
    },
],
  3. Invoke command Run Single from command pallet or shortcut
  4. See error trace
Trace ```typescript TypeError: 'isExtensible' on proxy: trap result does not reflect extensibility of proxy target (which is 'true') at Object.getExtension (c:\Users\Cabera.Jakub\.vscode-insiders\extensions\fabiospampinato.vscode-terminals-1.12.6\out\extension.js:9:72451) at Object.get (c:\Users\Cabera.Jakub\.vscode-insiders\extensions\fabiospampinato.vscode-terminals-1.12.6\out\extension.js:9:72979) at t.runTerminal (c:\Users\Cabera.Jakub\.vscode-insiders\extensions\fabiospampinato.vscode-terminals-1.12.6\out\extension.js:9:75835) at c:\Users\Cabera.Jakub\.vscode-insiders\extensions\fabiospampinato.vscode-terminals-1.12.6\out\extension.js:9:70363 at v._executeContributedCommand (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:578:927) at v.$executeContributedCommand (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:579:295) at f._doInvokeHandler (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:451:249) at f._invokeHandler (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:450:964) at f._receiveRequest (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:449:639) at f._receiveOneMessage (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:448:468) at c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:446:691 at l.fire (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:49:893) at _.fire (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:181:97) at c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:784:706 at l.fire (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:49:893) at _.fire (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:181:97) at t.PersistentProtocol._receiveMessage (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:185:451) at c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:182:635 at l.fire (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:49:893) at f.acceptChunk (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:178:532) at c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:177:893 at Socket.t (c:\SCOOP\apps\vscode-insiders\nightly-20190916\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:186:930) at Socket.emit (events.js:200:13) at addChunk (_stream_readable.js:294:12) at readableAddChunk (_stream_readable.js:275:11) at Socket.Readable.push (_stream_readable.js:210:10) at Pipe.onStreamRead (internal/stream_base_commons.js:166:17) ```

A

VS Code version: Code - Insiders 1.39.0-insider (d157c2e941cae17acb79bf26a70bbfad732bdc83, 2019-09-16T06:06:10.647Z) OS version: Windows_NT x64 10.0.18362

System Info |Item|Value| |---|---| |CPUs|AMD A6-5400K APU with Radeon(tm) HD Graphics (2 x 3593)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: disabled_off
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|7.46GB (2.43GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions (18) Extension|Author (truncated)|Version ---|---|--- bracket-pair-colorizer-2|Coe|0.0.28 vscode-markdownlint|Dav|0.30.2 gitlens|eam|9.9.3 EditorConfig|Edi|0.13.0 vsc-material-theme|Equ|30.0.0 vsc-material-theme-icons|equ|1.0.6 vscode-terminals|fab|1.12.6 vscode-pull-request-github|Git|0.11.1 todo-tree|Gru|0.0.153 intellij-idea-keybindings|k--|0.2.34 vscode-docker|ms-|0.8.1 remote-containers|ms-|0.76.0 powershell|ms-|2019.5.0 errorlens|Phi|1.1.3 vscode-yaml|red|0.5.3 code-settings-sync|Sha|3.4.2 shellcheck|tim|0.8.1 markdown-all-in-one|yzh|2.4.2
aeschli commented 5 years ago

If I get this right it is cause by this line: a.workspace.getConfiguration().get(n);return t.configPath||delete t.configPath

Looks like a bug in the extension, configuration elements must not be modified.

ctf0 commented 5 years ago

same here on osx mojave 10.14.6 too

Ash258 commented 5 years ago

Seems like it was fixed in upstream. I can fire up select single terminal dialog without any issue right now.

fabiospampinato commented 4 years ago

@aeschli Did you guys reverted/postponed the change that broke this?

aeschli commented 4 years ago

@fabiospampinato Sorry, I don't know.

fabiospampinato commented 4 years ago

I'm closing this since it appears to be working again.

Ash258 commented 4 years ago

This was "fixed" in upstream with electron version downgrade to 4 from 6. microsoft/vscode@da76f05e7a1910fb4206267e5c59b8d20a203700

I suspect this will occur again as soon as electron version is bumped again after recovery phase.

Ash258 commented 4 years ago

As I thought. Issue is back with today insider.

image

Version: 1.40.0-insider
Commit: 72bc289d32ec4f867e73b7f1f2a22f7d614ae2bb
Date: 2019-10-11T05:44:05.506Z
Electron: 6.0.12
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362
msageryd commented 4 years ago

Is there a fix for this? Code was auto-updated to 1.40 and then stuff broke.

Should I downgrade code for now?

fabiospampinato commented 4 years ago

I'll try to push a fix soon-ish šŸ‘

msageryd commented 4 years ago

FYI. Downgrading Code to 1.39.2 works as a temporary solution.

promethyttrium commented 4 years ago

Tired of waiting for "soonish" -- gonna fork it and be done with it...

Update: Twas a simple two-line change (1 was pre-existing bug that caused webpack to fail). No idea why it's still not fixed here. At least I don't have to be on a downgraded version of VSCode anymore. Life can go on...

Msordet commented 4 years ago

@promethyttrium Can you make a PR then? :)

sketchbuch commented 4 years ago

Yeah a PR would be great!

madchops1 commented 4 years ago

A PR for this would be great eh! ;)

fabiospampinato commented 4 years ago

Fixed in 1.12.7, sorry for the delay but I recently relocated to London and trying to find some more permanent accommodation can be time consuming and not upgrading or downgrading was a viable option.

ahsan541 commented 4 years ago

installing vscode version 1.39 fixed my issue

tgmti commented 4 years ago

I needĀ“s to mutate VSCā€™s config object here

So I did this way:

//before: 
delete storage[profile];

// WorkArround
const newStorage = Object.keys(storage)
    .filter(sKey => sKey != profile)
    .reduce((obj: any, key: string)=> {
      obj[key] = storage[key];
      return obj;
    },{});

Works for me, hope helpĀ“s You