search

fabiospampinato / vscode-terminals

An extension for setting-up multiple terminals at once, or just running some commands.
MIT License
121 stars 19 forks source link

Add support for joining terminals #74

Closed alextegelid closed 10 months ago

alextegelid commented 1 year ago

Resolves #66 and #9

Please note: This PR will introduce an error in TypeScript:

Property 'location' does not exist on type 'TerminalOptions'.ts(2339)

However, the code runs and I think the error is a problem with location not being specified in the type declaration for vscode. The location property is in the api docs here: https://code.visualstudio.com/api/references/vscode-api#TerminalOptions

The error can be silenced by adding //@ts-ignore to line 143 in run.ts but I'll leave that to the maintainers.

alextegelid commented 1 year ago

FYI: I've now realized that the TS error above will have to be silenced to be able to package the extension.

JacobsonGal commented 1 year ago

Bravo! When will it be ready?

alextegelid commented 1 year ago

It depends on when the maintainers will be able to merge this PR. I'm running the development version myself 😁

JacobsonGal commented 1 year ago

How can i do it as well?

alextegelid commented 1 year ago

You can clone my repo, install all dependencies with npm install and then build the extension following this documentation and finally install from the newly created .vsix file.

alextegelid commented 1 year ago

@fabiospampinato any thoughts on this so far?

Akronae commented 1 year ago

@alextegelid You should probably make a fork and publish it, looks like Fabio does not have the time to manage this extension anymore. I'd gladly install yours!

alextegelid commented 1 year ago

I've got a fork right here: https://github.com/alextegelid/vscode-terminals

But you'll have to build it yourself. See my comment above regarding building it.

fabiospampinato commented 10 months ago

It looks like the linked issues got closed already, so this PR should not be relevant anymore, sorry.