search

fabiotosi92 / NeRF-Supervised-Deep-Stereo

A novel paradigm for collecting and generating stereo training data using neural rendering
https://nerfstereo.github.io/
MIT License
348 stars 19 forks source link

A potential bug related to using uint16 to store AO maps #27

Closed husheng12345 closed 1 year ago

husheng12345 commented 1 year ago

Hello, I've found a potential bug regarding the storage method of AO maps. The range of AO is [0,1], it's multiplied by 65536 and then saved as a uint16 PNG image. However, when AO equals exactly 1, 65536 exceeds the maximum value of uint16. This results in AO being incorrectly stored as 0. Here's a visualization example; the white areas in the second image represent where AO=0. (0005/Q/AO/IMG_20220818_180012.png) IMG_20220818_180012 temp

fabiotosi92 commented 1 year ago

Hi! We're grateful for your observation regarding AO map storage. You're right, when AO is 1, it turns into 0 due to uint16 limits. While we did overlook this issue, it's important to highlight that the exclusion of these points, even though they are highly reliable, is unlikely to have a significant impact on our quantitative results. This is because these points represent a very low density, and they are generally indicative of regions where stereo matching is relatively easy.

Once again, thank you for your valuable observation!