search

fablab-bergamo / Fab-O-matic

RFID machine access solution for a Fab Lab, based on ESP32. Uses modern C++ with Arduino framework. Hardware project is included.
https://www.fablabbergamo.it/2024/06/03/fabomatic1/
MIT License
2 stars 3 forks source link

Implementation of comments of PR #1 #2

Closed PBrunot closed 1 year ago

PBrunot commented 1 year ago

I have implemented most comments of PR #1 I have refactored slightly the LCDWrapper so that the users of this class do not need to use setRow() It compiles, but it was not tested on real hardware.

valerionew commented 1 year ago

In generale mi sembra okay, fammi sapere se riesci a validare anche sull'hardware

PBrunot commented 1 year ago

@lestofante : Enlightening comments thank you @valerionew : I will test on hardware (I got everything from the FabLab now). I will comment again here when it's ready to merge.

PBrunot commented 1 year ago

@valerionew tested successfully with LCD, RFID reader and ESP32S3. With respect to your baseline, there are no real functional difference, only I went through all comments by @MauroMombelli / @lestofante and the code should be ready to work on server integration.

valerionew commented 1 year ago

I'd say let's merge this in main for now, then we can proceed adding features