search

fablabbcn / fablabs.io

The platform of the global Fab Labs Network
https://fablabs.io
GNU Affero General Public License v3.0
67 stars 33 forks source link

Sets a default scope for Doorkeeper OAuth gem #588

Closed MacTwister closed 2 years ago

MacTwister commented 2 years ago

From Doorkeepr version 5.2.x onwards, a scope param needs to be provided for oauth requests. This default scope will be used for applications/requests that do not specify one.

I've gone with the doorkeepr default scope of public as we only use this mostly for 3rd party login and have no APIs using scopes, so public felt appropriate to me as in "Access your public data".

With this change we can safely upgrade to the latest v5 of Doorkeeper.

Can close #587

viktorsmari commented 2 years ago

@MacTwister I merged the PR and then found some tests were failing - I did not notice before, because I had to update the Github Actions CI.

I quickly reverted in https://github.com/fablabbcn/fablabs.io/commit/6d17038d4bc9ee412430c67239fefdcf877c75ca

I am not working on this project anymore, but maybe you can check why the tests were failing?

MacTwister commented 2 years ago

@viktorsmari Ok, sure. I don't think scope has an effect on anything because it just a default. Not sure on Actions CI, but I'll have a look at code again, run the tests locally. and make new PRs Thanks