Closed oscgonfer closed 9 months ago
We should also look into a better way of handling host-specific docker-compose config - one option would be to have a checked-in docker-compose.example.yml
and ignore docker-compose.yml itself (then update the github actions and readme to make it clear this needs to be copied), or maybe there's something in https://docs.docker.com/compose/multiple-compose-files/ we could use to copy out host-specific stuff into includes?
Oh, i've also just split out the compose.yml file into an include for each service, which should make things more manageable!
Hi @timcowlishaw Very nice and neat upgrade. Thanks.
Some improvements I would suggest for documentation:
docker compose
> 2.20. I would suggest having a documented way to make sure people can easily see what version is needed.README.md
, although updated, is confusing in general (it was before already). If possible, I would ask to various sections with step by step processes for:
@timcowlishaw Is it OK for me to merge? Maybe we can solve https://github.com/fablabbcn/smartcitizen-api/pull/248#issuecomment-1833441449 documentation briefl while is fresh before merging or would you rather do it on a separate issue?
Hey @oscgonfer ! Aha sure thing, that sounds sensible - i can get to the documentation part later this week!
This branch is to add changes on the docker-compose example file, in particular to make use of resource limitations and better restart policies of services.
Bear in mind that there is no more version at the beginning of the file, or there shouldn't be.
235