fablabbcn / smartcitizen-api

The Smart Citizen Engine
https://developer.smartcitizen.me
GNU Affero General Public License v3.0
10 stars 4 forks source link

add extra logging for mqtt message handler JSON errors #261

Closed timcowlishaw closed 12 months ago

timcowlishaw commented 1 year ago

This is some extra instrumentation to help us track down what's going on in #251 - we can't currently see what messages are causing those exceptions. This should add them to the error notifications in Sentry.

oscgonfer commented 1 year ago

@timcowlishaw Should I merge directly to master and deploy this one in production?

timcowlishaw commented 1 year ago

Aha, might be worth me popping in next week and us doing it then just in case anything is wrong with it? But yep, it'd be good to have it in production so we get more info on the errors in sentry

El dv., 6 oct. 2023, 15.30, oscgonfer @.***> va escriure:

@timcowlishaw https://github.com/timcowlishaw Should I merge directly to master and deploy this one in production?

— Reply to this email directly, view it on GitHub https://github.com/fablabbcn/smartcitizen-api/pull/261#issuecomment-1750686267, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABBN3JPQESGO2EOXXRFOLX6ABXJAVCNFSM6AAAAAA5UQKQVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGY4DMMRWG4 . You are receiving this because you were mentioned.Message ID: @.***>

sentry-io[bot] commented 12 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

timcowlishaw commented 12 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

* ‼️ **JSON::ParserError: unexpected character (after ) at line 1, column 2 [parse.c:764] in '{'hey': 'nooo; oooaf[][];\t}** `app/lib/mqtt_messages_handler.rb in parse` [View Issue](https://iaac.sentry.io/issues/4537762899/?referrer=github-pr-bot)

Did you find this useful? React with a 👍 or 👎

This is the expected behaviour :-) 👍