fablabbcn / smartcitizen-api

The Smart Citizen Engine
https://developer.smartcitizen.me
GNU Affero General Public License v3.0
10 stars 4 forks source link

Better name for `hardware.info`? #309

Closed oscgonfer closed 7 months ago

oscgonfer commented 7 months ago

Easy one, do we think that we can find a better, more understandable name, for hardware.info? We were talking with @pral2a about it and we thought that it would be weird for an user to see it, and it be [filtered]. Maybe something like last_report?

timcowlishaw commented 7 months ago

Hmm very happy to do this, but not sure last_report is particularly descriptive either (i'd expect that to be the datetime of the last time the device updated the info). Maybe last_reported_hardware_info?

oscgonfer commented 7 months ago

what about hardware.last_status or hardware.last_status_report

pral2a commented 7 months ago

Yes, two me both sound perfect. Also instead of report we can also think of message as hardware.last_status_message

timcowlishaw commented 7 months ago

ok perfect, last_status_message it is!

On Thu, 7 Mar 2024 at 15:13, Pral2a @.***> wrote:

Yes, two me both sound perfect. Also instead of report we can also think of message as hardware.last_status_message

— Reply to this email directly, view it on GitHub https://github.com/fablabbcn/smartcitizen-api/issues/309#issuecomment-1983724025, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABBN2XMAOOYR2ZCN6O3YTYXB7YHAVCNFSM6AAAAABEFRCCDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTG4ZDIMBSGU . You are receiving this because you were assigned.Message ID: @.***>

timcowlishaw commented 7 months ago

Done in 5b1e73f!