search

fablabbcn / smartcitizen-enclosures

Enclosures for Smart Citizen
Other
17 stars 13 forks source link

This is my new enclosures contribution #2

Closed Prius1954 closed 4 years ago

oscgonfer commented 4 years ago

Before merging, could you rename the folders and maybe put them in the outdoor enclosures?

Thanks

Prius1954 commented 4 years ago

Hi Oscar

The blind hole is indeed a very good idea!!

Will do and come back.

Best

Andreas Manz

El 21 feb 2020, a las 18:07, oscgonfer notifications@github.com escribió:

 @oscgonfer approved this pull request.

Hi @Prius1954

Thanks for the amazing work! I am merging the request now.

On a side note, do you think the hole in the back (for the hook) could be blind? This way if exposed in outdoor conditions it wouldn't leak water in.

Thanks again! ❤️

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Prius1954 commented 4 years ago

Yes, I’ll also do this.

Kind regards

Andreas Manz

El 21 feb 2020, a las 18:23, oscgonfer notifications@github.com escribió:

 Before merging, could you rename the folders and maybe put them in the outdoor enclosures?

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

oscgonfer commented 4 years ago

Hi @Prius1954,

How is this going?