search

fablabbcn / smartcitizen-kit-20

Smart Citizen Kit 2.0 hardware and firmware
https://smartcitizen.me
GNU General Public License v3.0
37 stars 9 forks source link

add command to dim brightness of led #28

Closed freshprince closed 5 years ago

freshprince commented 5 years ago

As mentioned in https://forum.smartcitizen.me/t/disable-led-for-indoor-use/1150 I was also interested in a way to darken or disable LEDs.

~I implemented a command to crudely dim the brightness of the status LED.~ I would love to be able to also dim the USB and WiFi LEDs but right now I have no idea how to interface with ~the ESP or~ the bootloader (I also don't have the means to flash the bootloader). ~Also, if one sets the brightness level to 0.0 and then back up to anything else, the pulse animation won't continue because I killed the timer and was too lazy to implement that case. I can change that if requested.~ EDIT: By storing dimled in Configuration I fixed some of the problems and also have an idea how to interface with the ESP now.

This was tested on one of my own SCK2.1.

Would be happy about any feedback.

vicobarberan commented 5 years ago

Hi freshprince!

We just moved all Smartcitizen Kit 2.1 firmware code to a new repository here old repo will be just for legacy 2.0 hardware. I don't know which is the proper way to move your pull request and code to the new repository, maybe the simplest way is if you open the pull request again in the other repository?

I haven't had time yet but i will review and integrate your code as soon as possible.

Thank you!