fixed at 90 dpi - not compatible with inskcape 0.92

fablabnbg / inkscape-paths2openscad

Inkscape extension for designing simple 3D objects (2.5D actually) with inkscape. DOWNLOAD: https://github.com/fablabnbg/inkscape-paths2openscad/releases/latest

http://www.thingiverse.com/thing:25036/#comment-1233550

GNU General Public License v2.0

75 stars 18 forks source link

fixed at 90 dpi - not compatible with inskcape 0.92 #1

Open jnweiger opened 7 years ago

jnweiger commented 7 years ago

With upcoming inkscape 0.92 the internal dpi setting changes from 90 to 96. This extension uses a hardcoded 90. See also https://github.com/t-oster/VisiCut/issues/347

jnweiger commented 7 years ago

It does not work reliably: 1) When the document was saved or loaded before an extension is called, then we have elements inkscape:version="0.92.1 unknown" sodipodi:docname="box.svg" in the document. If it was never saved, both are missing, even with inkscape-0.92

2) if inkscape:document-units="mm" the px dpi should not matter. Currently they do.

jnweiger commented 7 years ago

Workaround works when we have a viewbox. Still possibly an inkscape bug? There should not be a difference before and after saving!