fable-compiler / Fable.Package.SDK

MIT License
9 stars 0 forks source link

Adding Fable.Package.SDK confuses IDE #9

Closed Lanayx closed 2 weeks ago

Lanayx commented 2 weeks ago

I found this issue some time ago and thought it was related to Rider https://youtrack.jetbrains.com/issue/RIDER-118632/F-syntax-highlight-suddenly-stopped-working-in-a-project But recently I found that Visual Studio gets confused as well image And when trying to open that highlighted file, it fails with catastrophic failure image

MangelMaxime commented 2 weeks ago

This is strange because Ionide as no problem and build works so MSBuild is happy.

I checked with EasyBuild.PackageReleaseNotes.Tasks which also customise MSBuild process and that one works.

So perhaps, I am doing something different here. The problem, is to debug it without any log or error is not going to be fun 😅

MangelMaxime commented 2 weeks ago

Someone on Discord mentioned that it is failing with current VS but preview (17.12) works fine with it.

Which seems to point out that the problem is coming from the IDE more than this package implementation.

Lanayx commented 2 weeks ago

The issue is preserved in VS Preview, I created the issue for VS as well: https://developercommunity.visualstudio.com/t/Adding-FablePackageSDK-confuses-Visual/10772429?

MangelMaxime commented 2 weeks ago

This should be fixed by version 1.2.0

MangelMaxime commented 2 weeks ago

Version 1.3.0 improves the fix for this issue, by not touching the File added by the user and instead rely on MSBuild internal target to copy the files only when packaging the package.