Closed MangelMaxime closed 4 weeks ago
@MangelMaxime Perhaps something like this? (untested, pseudo-code):
let overloadSuffix = memb.CurriedParameterGroups |> OverloadSuffix.getHash entGenParams
let memberName = memb.CompiledName + "_" + overloadSuffix
Maybe don't add suffix for getters or setters, and no "_" if suffix is empty.
@ncave Thank you, you allowed me to go in the right direction.
This needs a bigger rewrite than I thought at first, but it seems doable. I am working on it.
Fix #3863
@ncave I was looking into fixing #3863 and manage to fix that specific case however, if the members as an argument different than
unit
then it doesn't work because that member should me mangled.The difficulty is
Mangle
name computation happens duringFSharp2Fable
transformation, but for interfaces we don't do it.How should we approach this problem? Should we try to add
Mangle
information for interface too which means making a changes toFable.AST
or can we recompute theMangle
/HashSuffix
using FableEntity instead of FSharpEntity?