search

fable-compiler / fable-arch

Framework for building applications based on the elm architecture.
https://fable-compiler.github.io/fable-arch/
Apache License 2.0
60 stars 14 forks source link

App node selector #72

Closed Zaid-Ajaj closed 7 years ago

Zaid-Ajaj commented 7 years ago

instead of just startWithNodeSelector that only lets you select a dom node that gets mounted, I added startWithNode to be able to give it the target node directly (I still have no idea why every other commit ahead of master is in this PR :sweat_smile: haha)

MangelMaxime commented 7 years ago

I anwser you in PM on gitter.

So I will delay this PR when the feature/independant_sample will be merge inside master to help have a clean commit history.

Also, seems like your PR is failing the test. Please try to execute node build.js on your computer and you should see this errors: https://travis-ci.org/fable-compiler/fable-arch/builds/204724208