search

fable-compiler / fable-arch

Framework for building applications based on the elm architecture.
https://fable-compiler.github.io/fable-arch/
Apache License 2.0
60 stars 14 forks source link

Added startWithNode for virtual-dom renderer #73

Closed Zaid-Ajaj closed 7 years ago

MangelMaxime commented 7 years ago

In this PR we should also support startWithNode for React renderer too.

Zaid-Ajaj commented 7 years ago

Done! I was not sure if the React renderer would be affected because withStartNode operated on AppSpecification but after looking at the react sample I saw I was wrong :)

The travis-ci fails with this:

The command "sudo apt-get install -qq mono-complete mono-vbnc fsharp nuget referenceassemblies-pcl" failed and exited with 100 during .
MangelMaxime commented 7 years ago

Thanks for added the React support.

Yes I just saw this error in the Travis logs... I will need to take a look but it's really strange because I didn't change the Travis configuration. Perhaps there was an update of the container by the community.

Zaid-Ajaj commented 7 years ago

It is strange indeed, maybe @alfonsogarciacaro knows something about this (travis-ci failing)?

alfonsogarciacaro commented 7 years ago

I also had problems with Travis C# container in recent days, but it seems they've been solved. I just closed and reopened the PR to force a new build. Crossing fingers... :)

Zaid-Ajaj commented 7 years ago

@alfonsogarciacaro It worked :) Thanks a lot!!!