search

fable-compiler / fable-elmish-electron-material-ui-demo

Complete boilerplate for Electron apps using Fable and Elmish with hot module reloading, time-travel debugging, etc.
MIT License
113 stars 19 forks source link

Universalify not properly installed during build #6

Closed rdparker closed 5 years ago

rdparker commented 5 years ago

When trying to build the system, yarn does not properly install universalify.

 Directory of D:\repos\fable-elmish-electron-material-ui-demo\node_modules\universalify

04/05/2019  09:14 AM    <DIR>          .
04/05/2019  09:14 AM    <DIR>          ..
10/26/1985  04:15 AM             1,100 LICENSE
10/26/1985  04:15 AM               820 package.json
10/26/1985  04:15 AM             2,008 README.md
               3 File(s)          3,928 bytes
               2 Dir(s)  624,319,066,112 bytes free

This results in an electron failure later in the process.

Starting target 'YarnInstall'
.> "C:\Program Files (x86)\Yarn\bin\yarn.CMD" install (In: false, Out: false, Err: false)
yarn install v1.6.0
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@1.2.7: The platform "win32" is incompatible with this module.
info "fsevents@1.2.7" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
[1/3] ⢀ jss:  > https://opencollective.com/jss/donate
[2/3] ⢀ electron
[3/3] ⢀ node-sass
[-/3] ⠠ waiting...
error D:\repos\fable-elmish-electron-material-ui-demo\node_modules\electron: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: D:\repos\fable-elmish-electron-material-ui-demo\node_modules\electron
Output:
module.js:545
    throw err;
    ^

Error: Cannot find module 'universalify'
    at Function.Module._resolveFilename (module.js:543:15)
    ...

I tried adding universalify to paket.dependencies, but this didn't help. I also ran npm i which installed it correctly, including the missing index.js, but as soon as I run fake.cmd build -t Dev, yarn deletes it again and I'm right back where I started.

cmeeren commented 5 years ago

Just did a re-build on AppVeyor and it (still) builds fine. Which OS are you using?

rdparker commented 5 years ago

Windows 10 Pro Build 18362

cmeeren commented 5 years ago

Since AppVeyor is also Windows-based, I think the issue must be something local to your environment. Closing for now, but please let me know if you disagree, or come across more information that indicates this is something that can and should be solved in this repo. Or just have any clarification at all, really. :)