fable-compiler / fable-graphics

Fable bindings for graphic tools: D3, DC, Three, Pixi
https://fable-compiler.github.io/fable-graphics/
Apache License 2.0
23 stars 8 forks source link

Bump to Pixi 4.x #14

Closed realvictorprm closed 6 years ago

realvictorprm commented 7 years ago

We should track the progress for Pixi 4.x

realvictorprm commented 7 years ago

I've started with automatic generated ones here https://github.com/realvictorprm/fspixi

realvictorprm commented 7 years ago

@MangelMaxime what about posting your current binding here?

MangelMaxime commented 7 years ago

My bindings isn't complete for Pixi 4.x so it's would lead to problem for user ATM

realvictorprm commented 7 years ago

Do we have tests in here? if not we must introduce them with your binding to see the edge cases.

MangelMaxime commented 7 years ago

No we don't have test in the repo.

But we have samples. Also, the edge case are not the one explored into the samples as they are still really simply.

realvictorprm commented 7 years ago

Hate me if I suggest tests but though it was a hard lesson, tests are useful. I'll introduce some tests for PIXI

MangelMaxime commented 7 years ago

Sure if you can add test would be appreciate :)

whitetigle commented 7 years ago

@realvictorprm what do you mean by tests? This kind of tests?

MangelMaxime commented 7 years ago

That's the question I was aking myself @whitetigle after all.

whitetigle commented 7 years ago

That's exactly what I was thinking about @MangelMaxime! 😆

whitetigle commented 6 years ago

Hi @realvictorprm. I've got a simple question for you: are your bindings ready to use and so can we update ours with yours? Or do we need to do it? I'm asking you since I'm going to start working on this topic in the next days. Thanks!

realvictorprm commented 6 years ago

Hey :)

Unfortunately they aren't, I didn't spend time on them again because I had difficulties with understanding how it's done correctly.

Am 27.09.2017 10:21 AM schrieb "Whitetigle" notifications@github.com:

Hi @realvictorprm https://github.com/realvictorprm. I've got a simple question for you: are your bindings ready to use and so can we update ours with yours? Or do we need to update ours. I'm asking you since I'm going to start working on this topic in the next days. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fable-compiler/fable-graphics/issues/14#issuecomment-332446998, or mute the thread https://github.com/notifications/unsubscribe-auth/AYPM8NXGaOCg4RqWWs-YIy7CizwDhhXKks5smgWZgaJpZM4N5uSe .

whitetigle commented 6 years ago

ok! Thanks @realvictorprm! I'm going to start working on this right now then. Will ping back here when I get something working.

whitetigle commented 6 years ago

Hi!

New repo for the pixi bindings will be in fable-import. I will post prod ready bindings there.

Meanwhile, a first working version of the bindings can be found here and all the basic samples have been upgraded to pixi v4.5.5 and to the new pixi architecture (mostly using Application and Ticker now)

You can find the source here.

I will go on porting the other samples. But as of now, I think we should be ok with most current usages.

Next discussions will take place in sample-pixi repo from now on.

Have fun! image