search

fable-compiler / fable-promise

Fable bindings for JS promise
http://fable.io/fable-promise/
MIT License
19 stars 7 forks source link

Add Promise.any, Promise.allSettled, Promise.race #35

Closed AngelMunoz closed 2 years ago

AngelMunoz commented 2 years ago

This PR adds a couple of "new" (they have been on browsers for a while) Promise methods

I also added an active pattern + Result returning function to work easier with results from the allSettled function.

Let me know if you have any feedback about it

alfonsogarciacaro commented 2 years ago

@AngelMunoz We can merge as is for now and later add any2/any3... race2/race3... for promises with different types if needed. What do you think?

AngelMunoz commented 2 years ago

Yeah I think we can do that for now and generate a Non Generic Promise version for these kind of scenarios I'll try to tackle that one later

alfonsogarciacaro commented 2 years ago

@AngelMunoz Oh, my. I thought we had merged this, sorry for that! 🤦 Should we do it now?

AngelMunoz commented 2 years ago

Oh my, I'll try to send this one again, I did a clean up in my forks and archives and didn't see I had a PR for this one