search

fable-compiler / fable-react-native

Fable bindings and helpers for React Native projects
Apache License 2.0
49 stars 11 forks source link

Add a button #20

Closed forki closed 6 years ago

forki commented 6 years ago

@alfonsogarciacaro hugs!

alfonsogarciacaro commented 6 years ago

Done! BTW, you are also an owner of the nuget package, so you should be able to publish new versions if you need them fast. Just edit RELEASE_NOTES and run build.cmd GithubRelease (the script expects a NUGET_KEY env var).

forki commented 6 years ago

got it. thanks

forki commented 6 years ago

that nuget_key env variable is a dangerous thing - would love to pass it by command line arg instead

forki commented 6 years ago

ok passing from cmd line works but I get PUT methodnotallowed from dotnet nuget push

Why are you not pushing with paket?

alfonsogarciacaro commented 6 years ago

Hmm, that's weird. Paket push was giving problems (I think we already talked about that in a couple of other GH issues but don't remember where) and I changed it to dotnet push and it was working, so...

forki commented 6 years ago

what problems? I seriously never had one.

alfonsogarciacaro commented 6 years ago

https://github.com/fable-compiler/fable-import/issues/33