search

fable-compiler / fable-react-native

Fable bindings and helpers for React Native projects
Apache License 2.0
49 stars 11 forks source link

Missing currentHeight static property for StatusBar #28

Closed thitemple closed 6 years ago

thitemple commented 6 years ago

According to the RN docs the StatusBar api has a static member called currentHeight that is available only to Android but its available on the main StatusBar object.

I thought of adding it here:

https://github.com/fable-compiler/fable-react-native/blob/3966bd126a223d394965897ef988c9fbe9cfdbec/src/Fable.Import.ReactNative.fs#L1900

with something like: abstract currentHeight: float with get

but I'm not sure if it's the right approach, if it is, I'm happy to send a PR or with whatever you think is best

alfonsogarciacaro commented 6 years ago

I haven't used much RN but looks like the right place to me :) (if @forki doesn't say anything against) We would happily accept a PR. Please check if the property is also mutable and it'd be nice to also add a doc comment to specify it's only for Android :+1:

forki commented 6 years ago

Yes PR please

Alfonso Garcia-Caro notifications@github.com schrieb am Mi., 11. Juli 2018, 22:00:

I haven't used much RN but looks like the right place to me :) (if @forki https://github.com/forki doesn't say anything against) We would happily accept a PR. Please check if the property is also mutable and it'd be nice to also add a doc comment to specify it's only for Android 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fable-compiler/fable-react-native/issues/28#issuecomment-404292229, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNHi1cTuGlZFxRnNkwmzNFzUe8BChks5uFllzgaJpZM4VLg65 .