search

fable-compiler / fable-react-native

Fable bindings and helpers for React Native projects
Apache License 2.0
49 stars 11 forks source link

Geotype #30

Closed thitemple closed 6 years ago

thitemple commented 6 years ago

This will add types to the GeolocationReturnType.

Base on the RN documentation, it is extending the Browser's Geolocation API so it returns this:

https://developer.mozilla.org/en-US/docs/Web/API/Position

alfonsogarciacaro commented 6 years ago

Thanks @thitemple! Apparently a mysterious (and big) file sneaked into the PR (src/Fable.Import.ReactNative.fs.orig). Can you please remove it?

thitemple commented 6 years ago

Done, sorry about that

alfonsogarciacaro commented 6 years ago

NP, thank you! 😸

alfonsogarciacaro commented 6 years ago

I forgot the latest version is an alpha version, so I published the new one as 2.0.0-alpha-002 (meaning you need to add prerelease in paket.dependencies to download it). Is that OK for you?

thitemple commented 6 years ago

That's how I have it right now ;) Thanks