Various fixes - Githubissues

iyegoroff commented 6 years ago

changed IImageSourceProperties list to IImageSource and added functions for fetching remote images remoteImage and remoteImages: https://github.com/iyegoroff/fable-react-native/blob/ea8bf8ff51a1d702edb9db44620fb13a35194cfe/src/Fable.Helpers.ReactNative.fs#L1497-L1501
updated Switch and Slider components;
removed deprecated SwitchIOS and SliderIOS components;
updated FlatListProperties and added IFlatListProperties interface to ScrollViewProperties;
updated ScrollViewProperties;
renamed function Dip to dip and Pct to pct to conform other function's naming style;
put WebViewBundleSource above ImageURISourceProperties, so now Uri is inferred as ImageURISourceProperties.Uri which is more commonly used than WebViewBundleSource.Uri;
added RequireQualifiedAccess to FlexDisplayType to prevent conflict with Option.None;
several fixed typos & minor fixes;

alfonsogarciacaro commented 6 years ago

Awesome, thanks a lot for this @iyegoroff! This looks good to me :+1: If @forki can have a quick look it'd be nice, if not I'll just merge and publish a new release tomorrow :)

forki commented 6 years ago

Please merge

Alfonso Garcia-Caro notifications@github.com schrieb am So., 29. Juli 2018, 12:45:

Awesome, thanks a lot for this @iyegoroff https://github.com/iyegoroff! This looks good to me 👍 If @forki https://github.com/forki can have a quick look it'd be nice, if not I'll just merge and publish a new release tomorrow :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fable-compiler/fable-react-native/pull/32#issuecomment-408667844, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNPl7vNfyWtGefc5XXo1UrV8mFAGkks5uLZJSgaJpZM4VkuL9 .

alfonsogarciacaro commented 6 years ago

Published as 2.0.0-alpha-003. Thanks again for all your help to improve Fable on RN @iyegoroff! 🥇

fable-compiler / fable-react-native

Various fixes #32