search

fable-compiler / fable-react-native

Fable bindings and helpers for React Native projects
Apache License 2.0
49 stars 11 forks source link

Animated view #36

Closed thitemple closed 5 years ago

thitemple commented 6 years ago

I was trying to create some animations and realized I could not create the Animated components so I added these to the typings.

Please let me know if it is good enough, and any changes needed.

Also, how do you test this locally? When I build it with FAKE there is no usable output, what am I missing. Thanks.

alfonsogarciacaro commented 6 years ago

Looks good, there should be no problems to merge. TBH, I haven't really used ReactNative so we don't really test things 😅 I'm just hoping that @forki is having a look and making sure everything works fine :wink:

thitemple commented 6 years ago

Yeah, I copied the Fable.Helpers.ReactNative and Fable.Import.ReactNative files into my project and tested them from there. I have some adjustments and I will push them tomorrow.

I will also use your suggestion for the Object.assign and push that as well. All my changes are related to RN animations.

iyegoroff commented 6 years ago

Hi, @thitemple , do you have something else to push or this can be merged as is?

forki commented 5 years ago

ok I merged it and upgraded it to the Fable.Core 3 - you can use 2.0.0-beta-013