search

fable-compiler / fable-react-native

Fable bindings and helpers for React Native projects
Apache License 2.0
49 stars 11 forks source link

Update to Fable 2.0 #41

Closed forki closed 5 years ago

forki commented 5 years ago

fixes #39

@alfonsogarciacaro any chance you can take a look and release it? I really want to move my RN project to fable 2 - so that I don't need to bug you about bugs in fable 1.x :P

/cc @MangelMaxime

MangelMaxime commented 5 years ago

@forki Latest version of Fable.React.Native is 2.0.0-alpha-014 should I release it as 2.0.0-alpha-015 or 3.0.0-alpha-001 ?

forki commented 5 years ago

How about 2.0 proper?

Am Mi., 20. Feb. 2019, 11:11 hat Maxime Mangel notifications@github.com geschrieben:

@forki https://github.com/forki Latest version of Fable.React.Native is 2.0.0-alpha-014 should I release it as 2.0.0-alpha-015 or 3.0.0-alpha-001 ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fable-compiler/fable-react-native/pull/41#issuecomment-465510893, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNPapU2koK0_l45W3wgxiWpkkwSZBks5vPR9KgaJpZM4bEvm9 .

MangelMaxime commented 5 years ago

I was proposing v3 because v2 alpha was for Fable 1.x support.

@forki Is it working or do we need an alpha/beta version first?

forki commented 5 years ago

I don't know yet so yes alpha would be good

MangelMaxime commented 5 years ago

@forki I fixed the errors and warnings but I didn't test the project. I don't have a RN app and never created one 😊

Now we need to wait after nuget

forki commented 5 years ago

thanks! the question now is: how to do the rest of https://github.com/SAFE-Stack/SAFE-Nightwatch/issues/64 - Imean we don't have webpack here