search

fable-compiler / fable-react-native

Fable bindings and helpers for React Native projects
Apache License 2.0
49 stars 11 forks source link

ViewPager has moved #47

Closed forki closed 5 years ago

forki commented 5 years ago

/cc @MangelMaxime

MangelMaxime commented 5 years ago

Do you want me to merge and release?

forki commented 5 years ago

yes please, but the question is if we should separate it as well at some point

MangelMaxime commented 5 years ago

What do you mean by separate?

Are @react-native-community/ and react-native a different packages?

forki commented 5 years ago

Yes they extracted a lot of the core features into separate packages to have a smaller core

Maxime Mangel notifications@github.com schrieb am Di., 12. März 2019, 18:02:

What do you mean by separate?

Are @react-native-community/ and react-native a different packages?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fable-compiler/fable-react-native/pull/47#issuecomment-472090728, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNE6wCr53E9muqY1g3ZdAtP0DYOhCks5vV924gaJpZM4brCKL .

MangelMaxime commented 5 years ago

Then indeed IMHO it's better to split the package.

We can remove completely the Helper or let it mark it as Obselete to help people migrate. If we mark it as Obselete we can let the old implementation in place so the transition is smoother or just use jsNative to force people to migrate.

forki commented 5 years ago

I think for now I'd go with keeping it - at least until I found all the packages that were removed.

Maxime Mangel notifications@github.com schrieb am Di., 12. März 2019, 19:41:

Then indeed IMHO it's better to split the package.

We can remove completely the Helper or let it mark it as Obselete to help people migrate. If we mark it as Obselete we can let the old implementation in place so the transition is smoother or just use jsNative to force people to migrate.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fable-compiler/fable-react-native/pull/47#issuecomment-472131164, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNEFRZlMprb2CDqqDQcjFRIkMurZsks5vV_TKgaJpZM4brCKL .

forki commented 5 years ago

Ok I removed ViewPager and AsyncStorage from the main package