fable-compiler / fable-react-native

Fable bindings and helpers for React Native projects
Apache License 2.0
49 stars 11 forks source link

[WIP] Update to Fable.Core 3 and Fable.React 5 #50

Closed alfonsogarciacaro closed 5 years ago

alfonsogarciacaro commented 5 years ago

Sorry @forki, right after working on these files I noticed you also has another PR for the same purpose. I'll have a look so we can decide which PR we should work on.

This one for now updates dependencies and fixes the build for the three main files. I'm trying to rename the namespaces following the guidelines we've used in other packages:

Fable.Import.ReactNative > Fable.ReactNative.Types
Fable.Helpers.ReactNative > Fable.ReactNative

Well, the second one is actually Fable.ReactNative.Helpers but with AutoOpen attribute.

However, I think we should try to do the same thing as Fable.React 5: remove the (semi)automatic translations of Typescript bindings (the files starting with Fable.Import) because these are hard to maintain and don't add much value. I would only keep the necessary types to make the helpers work and advise the user to use Fable JS interop capabilities when they need to access parts of RN that are not exposed by the library.

forki commented 5 years ago

I'll merge mine into yours!