WIP: Update to net5.0 - Githubissues

fable-compiler / fable-react-native

Fable bindings and helpers for React Native projects

Apache License 2.0

49 stars 11 forks source link

WIP: Update to net5.0 #63

Closed tforkmann closed 3 years ago

tforkmann commented 3 years ago

[x] Update to net 5.0
[x] got rid of Thoth.Json
[x] removed simple store for now

tforkmann commented 3 years ago

We could support both frameworks

alfonsogarciacaro commented 3 years ago

If I'm not mistaken netstandard is compatible with net5, so the library would still be compatible with net5 projects without having to change the framework.

tforkmann commented 3 years ago

downgraded to netstandard2.0 now. @alfonsogarciacaro could you have a look again? thanks

tforkmann commented 3 years ago

@forki Can you release and merge?

forki commented 3 years ago

Why does it need a new release? This is only updating infrastructure!?

tforkmann commented 3 years ago

There is an issue with Thoth.Json so I was thinking to remove the dependency. https://github.com/thoth-org/Thoth.Json/issues/46 We could also wait to see if that bug can get solved.

alfonsogarciacaro commented 3 years ago

It may make sense to remove the Thoth.Json dependency anyways. Is it safe to remove simple store? Are we sure nobody else uses it?