Closed nojaf closed 5 years ago
This is probably related to the fact that I'm using fable-splitter withallFiles: true
.
I believe it tries to compile all files in Fable.React to my output folder.
Should the Fable.Helper.ReactServer.fs be wrapped with a #if !Fable
directive @alfonsogarciacaro?
Yes, that should be the easiest solution, would you mind to PR it? I'm concerned we're having many #if
directives in the code. Probably it would be better to do like Thoth.Json does and keep two different projects for each platform. But for that we would need a comprehensive test suite to make sure the API is consistent.
Happy to do PR. Maybe there is an other solution, is fable using the fsproj file inside the .fable
folder?
I'm trying to disable to compile tag with
<Compile Include="Fable.Helpers.ReactServer.fs" Condition="$(FABLE_COMPILER) == 'false'" />
.
This doesn't work but I'm not sure that fable looks at the proj file? Also not sure if what variables are available in msbuild.
Fable does indeed look at the project file (this is necessary to get the file order) but for .fsproj coming from Nuget packages, it just does a very simplistic resolution that doesn't check conditional. But anyways #124 should solve the problem, thank you!
Using
5.0.0-alpha-002
Hmm, also the same problem with 4.1.3