search

fable-compiler / fable-react

Fable bindings and helpers for React and React Native
MIT License
275 stars 66 forks source link

Removed Hyphen from CssProp #183

Closed SCullman closed 4 years ago

SCullman commented 4 years ago

CssProps are, unlike their options, no string enums. They MUST not have any hyphen. fixes #182

SCullman commented 4 years ago

@alfonsogarciacaro , this means also there is actually no need for a SnakeCase option.

forki commented 4 years ago

Thanks

Stefan Cullmann notifications@github.com schrieb am Mo., 14. Okt. 2019, 13:20:

@alfonsogarciacaro https://github.com/alfonsogarciacaro , this means also there is actually no need for a SnakeCase option.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fable-compiler/fable-react/pull/183?email_source=notifications&email_token=AAAOANHLAKULMYVZPVB7VBTQORIXFA5CNFSM4JANYNTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBEHRDQ#issuecomment-541620366, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOANA2Q4XQABU7RNIV36TQORIXFANCNFSM4JANYNTA .

MangelMaxime commented 4 years ago

Released in 5.3.4.

I didn't test the code, so if there is still a bug please open an issue or send a PR ;)

alfonsogarciacaro commented 4 years ago

I was about to include the remaining the remaining CSS Prop options in the new release, but you were faster than me @MangelMaxime ;)

Thanks for reporting @forki, this escaped to me in the previous PR.

@SCullman With the SnakeCase rule, we would be able to just write StringEnum(CaseRules.SnakeCase) for the CSS Prop options instead of having to manually add CompiledName in all multi-wod cases. It will be fixed anyways in the next version, but SnakeCase should be still be a valuable addition for the future.

forki commented 4 years ago

thanks for quick fix and release. Works for me!

Am Mo., 14. Okt. 2019 um 13:32 Uhr schrieb Maxime Mangel < notifications@github.com>:

Released in 5.3.4.

I didn't test the code, so if there is still a bug please open an issue or send a PR ;)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fable-compiler/fable-react/pull/183?email_source=notifications&email_token=AAAOANBEFVY2I7AAVFYUM3TQORKFJA5CNFSM4JANYNTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBEIUYQ#issuecomment-541624930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOANCIMEDHJLZ6XWKNX43QORKFJANCNFSM4JANYNTA .